Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0832/rxFS: fix delete block, hide search block #1854

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

GarboMuffin
Copy link
Member

@GarboMuffin GarboMuffin commented Jan 8, 2025

  • Delete blocks leave holes in the arrays, breaking other blocks
  • The search block has been broken this entire time (.indexOf(...) == undefined is always false). It's not clear what it's even supposed to do, so just hide it.

@GarboMuffin GarboMuffin changed the title Unlist rxFS rxFS: fix bugs and delist it Jan 8, 2025
@GarboMuffin GarboMuffin changed the title rxFS: fix bugs and delist it rxFS: fix bugs Jan 8, 2025
@GarboMuffin
Copy link
Member Author

GarboMuffin commented Jan 8, 2025

Ok I won't delist it yet, because there isnt a clear straightforward 1:1 replacement for it, for the few people that actually need this

@GarboMuffin GarboMuffin changed the title rxFS: fix bugs 0832/rxFS: fix bugs Jan 8, 2025
@GarboMuffin GarboMuffin changed the title 0832/rxFS: fix bugs 0832/rxFS: fix delete block, hide search block Jan 8, 2025
@GarboMuffin GarboMuffin merged commit b3960f5 into master Jan 8, 2025
3 checks passed
@GarboMuffin GarboMuffin deleted the rxfs-should-never-have-been-merged branch January 8, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant